Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

Fixing ldap form#444

Merged
yadvr merged 1 commit intoapache:masterfrom
shapeblue:fix-ldap-form
Jun 25, 2020
Merged

Fixing ldap form#444
yadvr merged 1 commit intoapache:masterfrom
shapeblue:fix-ldap-form

Conversation

@davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Jun 22, 2020

Fixes #112
Requires apache/cloudstack#4164 to list domain-specific LDAP configs

Screenshot from 2020-06-22 19-03-55

@yadvr yadvr added this to the 1.0-GA milestone Jun 22, 2020
@davidjumani
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/444 (JID-2100)

@davidjumani
Copy link
Contributor Author

@rhtyd good to go!

@davidjumani davidjumani marked this pull request as ready for review June 23, 2020 12:50
@davidjumani
Copy link
Contributor Author

@rhtyd good to go!

@davidjumani
Copy link
Contributor Author

@rhtyd Right now, listLdapUsers does not support search or pagination

@yadvr
Copy link
Member

yadvr commented Jun 24, 2020

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/444 (JID-2108)

@yadvr
Copy link
Member

yadvr commented Jun 24, 2020

@davidjumani add information pop-over like other forms, add doc-link to the custom form (somewhere put a <a-icon for question and link to this.$config.docBase + ....)
Also test/check against old UI.

Primate API call runs:

domainid: 78ec0573-03fb-4c02-872a-b0f3a86471dc
roleid: 16919363-5fe0-11ea-9a56-1e006800018c
timezone: ACT
networkdomain: net-domain
group: group
username: ldapman
command: importLdapUsers
response: json

Legacy UI runs:

command: importLdapUsers
domainid: e4874e10-5fdf-11ea-9a56-1e006800018c
account: acount-name
roleid: 16919363-5fe0-11ea-9a56-1e006800018c
timezone: Pacific/Johnston
networkdomain: net-domain
group: ldap-group
response: json

Mismatch account not passed, instead username? Also, the label 'Group' should say 'LDAP Group'. Check the form against old UI.

@davidjumani
Copy link
Contributor Author

@rhtyd In the legacy UI, although the default filter is 'No Filter', the initial listLdapUsrers call uses 'Any Domain' as its filter. In this case, using 'No Filter' for the initial listLdapUsrers call. Should I change it to match the legacy UI ?

@davidjumani davidjumani marked this pull request as draft June 24, 2020 15:56
@yadvr
Copy link
Member

yadvr commented Jun 25, 2020

@davidjumani can you discuss with @DaanHoogland ?

@davidjumani
Copy link
Contributor Author

Discussed with @DaanHoogland Good to go!

@davidjumani davidjumani marked this pull request as ready for review June 25, 2020 09:43
@DaanHoogland
Copy link
Contributor

looks good

@yadvr yadvr merged commit 93b9d33 into apache:master Jun 25, 2020
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] new ldap functionality

4 participants